mirror of
https://github.com/ZHANGTIANYAO1/teamspeak-music-bot.git
synced 2026-10-02 04:52:50 +08:00
saopig1andClaude Opus 4.8
3a34c01abb
Follow-up to the auto-pause fix: resume never fired when someone came back. Root cause (verified live against a TS3 server): the full-client library's command/response channel is dead whenever >=2 clients are connected anywhere on the server — clientlist, channellist and channelclientlist ALL time out (confirmed even with the two clients in different channels). So the moment a listener returns is exactly the moment occupancy can no longer be queried, and the query-based refreshOccupancy() can never observe the return -> no resume. Event channelID is also unusable (library reads notify `cid` but enter-view carries `ctid`, so it's always 0), so per-channel membership can't be derived from events either. Fix (minimal, asymmetric): keep PAUSE on the authoritative clientlist path (reliable precisely because it only succeeds when the bot is alone on the server — the only state pause should fire), and arm RESUME directly from the clientEnter push event. Because the bot only auto-pauses while alone, the sole way occupancy can return while autoPaused is set is a fresh connection, which arrives reliably as clientEnter. New pure predicate shouldResumeOnReturn() + _resumeIfReturning() resume iff autoPaused && paused; the resume branch routes through handleOccupancy(1) and NEVER pauses (userCount>0), so a spurious enter can only harmlessly resume. The bot's own enter at connect is a no-op (autoPaused is already false). This deliberately does NOT adopt a full event-tracked peer set: events don't reliably seed clients already present when the bot joins, so a count-from-events ==0 would reintroduce the false-pause bug we just fixed, and reconcile can't heal it (clientlist only works when alone). Pause must trust only the authoritative query; resume can trust the event. Net semantics: pause when the server is empty (bot alone), resume when someone connects. Channel granularity is impossible with this library. UI copy updated to say "服务器" instead of "频道", and the Settings toggle default corrected to false to match the backend default. cmdVote intentionally left as-is. Verified live: auto-paused bot + a real client connecting -> resume fires with no clientlist call in the path; bot's own enter and not-auto-paused enters do not resume. 311 unit tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
74 lines
3.2 KiB
TypeScript
74 lines
3.2 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import {
|
|
decideOccupancyAction,
|
|
occupancyFromClientList,
|
|
shouldResumeOnReturn,
|
|
} from "./auto-pause.js";
|
|
|
|
describe("decideOccupancyAction", () => {
|
|
it("pauses when empty while playing and enabled", () => {
|
|
expect(decideOccupancyAction("playing", false, true, 0)).toBe("pause");
|
|
});
|
|
it("does not pause when the feature is disabled", () => {
|
|
expect(decideOccupancyAction("playing", false, false, 0)).toBe("none");
|
|
});
|
|
it("does not pause when idle (nothing playing)", () => {
|
|
expect(decideOccupancyAction("idle", false, true, 0)).toBe("none");
|
|
});
|
|
it("does not pause when already paused", () => {
|
|
expect(decideOccupancyAction("paused", false, true, 0)).toBe("none");
|
|
});
|
|
it("resumes when re-populated and we auto-paused", () => {
|
|
expect(decideOccupancyAction("paused", true, true, 2)).toBe("resume");
|
|
});
|
|
it("does NOT resume a user-paused track on re-population", () => {
|
|
expect(decideOccupancyAction("paused", false, true, 2)).toBe("none");
|
|
});
|
|
it("does nothing when re-populated and already playing", () => {
|
|
expect(decideOccupancyAction("playing", false, true, 2)).toBe("none");
|
|
});
|
|
it("resume is independent of the enabled flag (we already auto-paused)", () => {
|
|
expect(decideOccupancyAction("paused", true, false, 1)).toBe("resume");
|
|
});
|
|
});
|
|
|
|
describe("occupancyFromClientList", () => {
|
|
it("returns null when the query failed (0 clients — bot itself is always present)", () => {
|
|
// This is the bug fix: a clientlist timeout makes getClientsInChannel()
|
|
// return [], which must be treated as "unknown", NOT as an empty channel.
|
|
expect(occupancyFromClientList(0)).toBeNull();
|
|
});
|
|
it("returns 0 other users when only the bot is in the channel", () => {
|
|
expect(occupancyFromClientList(1)).toBe(0);
|
|
});
|
|
it("excludes the bot itself from the count", () => {
|
|
expect(occupancyFromClientList(2)).toBe(1);
|
|
expect(occupancyFromClientList(5)).toBe(4);
|
|
});
|
|
it("never yields a negative count (guards the -1 that caused false pauses)", () => {
|
|
expect(occupancyFromClientList(-3)).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("shouldResumeOnReturn (event-driven auto-resume)", () => {
|
|
it("resumes when we auto-paused and are still paused", () => {
|
|
// The reported gap: someone returns after an auto-pause. clientlist can't
|
|
// confirm it (it times out while they're present), so we resume from the
|
|
// clientEnter event alone.
|
|
expect(shouldResumeOnReturn(true, "paused")).toBe(true);
|
|
});
|
|
it("does NOT resume a track the user paused by hand", () => {
|
|
expect(shouldResumeOnReturn(false, "paused")).toBe(false);
|
|
});
|
|
it("does nothing if already playing (e.g. the bot's own enter at connect)", () => {
|
|
// autoPaused is cleared to false on connect, so the bot's own clientEnter
|
|
// is a no-op; this also covers the playing/auto-paused-flag-stale case.
|
|
expect(shouldResumeOnReturn(false, "playing")).toBe(false);
|
|
expect(shouldResumeOnReturn(true, "playing")).toBe(false);
|
|
});
|
|
it("does nothing when idle (nothing to resume)", () => {
|
|
expect(shouldResumeOnReturn(true, "idle")).toBe(false);
|
|
expect(shouldResumeOnReturn(false, "idle")).toBe(false);
|
|
});
|
|
});
|